x86/svm: Fix handling of ICEBP intercepts
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 6 Jun 2019 12:09:20 +0000 (14:09 +0200)
committerJan Beulich <jbeulich@suse.com>
Thu, 6 Jun 2019 12:09:20 +0000 (14:09 +0200)
commit4f2d189bb9f2e80300a1434b1b1070d86e2fdff2
treecdd02109b4560979a0ee68137ed91eb867b2fe51
parentf06cc4f1828f725a980871c9c41eda875c946186
x86/svm: Fix handling of ICEBP intercepts

c/s 9338a37d "x86/svm: implement debug events" added support for introspecting
ICEBP debug exceptions, but didn't account for the fact that
svm_get_insn_len() (previously __get_instruction_length) can fail and may
already have raised #GP with the guest.

If svm_get_insn_len() fails, return back to guest context rather than
continuing and mistaking a trap-style VMExit for a fault-style one.

Spotted by Coverity.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
Acked-by: Brian Woods <brian.woods@amd.com>
master commit: 1495b4ff9b4af2b9c0f12cdb6491082cecf34f86
master date: 2019-05-13 10:35:37 +0100
xen/arch/x86/hvm/svm/svm.c